From: Arnd Bergmann Date: Thu, 20 Apr 2023 21:36:31 +0000 (+0200) Subject: net: dsa: qca8k: fix LEDS_CLASS dependency X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=33c1af8e2c75ab601524e25efeeed0173d703ce7;p=linux.git net: dsa: qca8k: fix LEDS_CLASS dependency With LEDS_CLASS=m, a built-in qca8k driver fails to link: arm-linux-gnueabi-ld: drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl': qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext' Change the dependency to avoid the broken configuration. Fixes: 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support") Signed-off-by: Arnd Bergmann Reviewed-by: Christian Marangi Reviewed-by: Andrew Lunn Link: https://lore.kernel.org/r/20230420213639.2243388-1-arnd@kernel.org Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/dsa/qca/Kconfig b/drivers/net/dsa/qca/Kconfig index 7a86d6d6a2463..4347b42c50fd2 100644 --- a/drivers/net/dsa/qca/Kconfig +++ b/drivers/net/dsa/qca/Kconfig @@ -19,7 +19,7 @@ config NET_DSA_QCA8K config NET_DSA_QCA8K_LEDS_SUPPORT bool "Qualcomm Atheros QCA8K Ethernet switch family LEDs support" depends on NET_DSA_QCA8K - depends on LEDS_CLASS + depends on LEDS_CLASS=y || LEDS_CLASS=NET_DSA_QCA8K help This enabled support for LEDs present on the Qualcomm Atheros QCA8K Ethernet switch chips.