From: Colin Ian King Date: Mon, 20 Mar 2017 14:08:50 +0000 (+0000) Subject: staging: vc04_services: fix NULL pointer dereference on pointer 'service' X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=35060a228e70c712cb626ef3eabaedc40903eb77;p=linux.git staging: vc04_services: fix NULL pointer dereference on pointer 'service' Currently, if pservice is null then service is set to NULL and immediately afterwards service is dereferenced causing a null pointer dereference. Fix this by bailing out early of the function with a null return. Detected by CoverityScan, CID#1419681 ("Explicit null dereferenced") Signed-off-by: Colin Ian King Acked-by: Stefan Wahren Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index dc9f85c2a5daa..4f9e738abddff 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -2673,7 +2673,7 @@ vchiq_add_service_internal(VCHIQ_STATE_T *state, if (!pservice) { kfree(service); - service = NULL; + return NULL; } service_quota = &state->service_quotas[service->localport];