From: Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
Date: Sat, 29 Apr 2017 23:10:03 +0000 (+0200)
Subject: livereload: Fix data race in close
X-Git-Tag: v0.21~83
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=355736ec357c81dfb2eb6851ee019d407090c5ec;p=brevno-suite%2Fhugo

livereload: Fix data race in close

Fixes #2625
---

diff --git a/livereload/connection.go b/livereload/connection.go
index 6e31b1ba..4e94e2ee 100644
--- a/livereload/connection.go
+++ b/livereload/connection.go
@@ -15,6 +15,7 @@ package livereload
 
 import (
 	"bytes"
+	"sync"
 
 	"github.com/gorilla/websocket"
 )
@@ -25,6 +26,16 @@ type connection struct {
 
 	// Buffered channel of outbound messages.
 	send chan []byte
+
+	// There is a potential data race, especially visible with large files.
+	// This is protected by synchronisation of the send channel's close.
+	closer sync.Once
+}
+
+func (c *connection) close() {
+	c.closer.Do(func() {
+		close(c.send)
+	})
 }
 
 func (c *connection) reader() {
diff --git a/livereload/hub.go b/livereload/hub.go
index 359bac3f..8ab6083a 100644
--- a/livereload/hub.go
+++ b/livereload/hub.go
@@ -41,14 +41,14 @@ func (h *hub) run() {
 			h.connections[c] = true
 		case c := <-h.unregister:
 			delete(h.connections, c)
-			close(c.send)
+			c.close()
 		case m := <-h.broadcast:
 			for c := range h.connections {
 				select {
 				case c.send <- m:
 				default:
 					delete(h.connections, c)
-					close(c.send)
+					c.close()
 				}
 			}
 		}