From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Tue, 5 Jul 2022 20:51:43 +0000 (+0200)
Subject: crypto: omap-sham - Drop if with an always false condition
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=35b22c19daa1bbe77dce2f7f776c0cf2acff1f00;p=linux.git

crypto: omap-sham - Drop if with an always false condition

The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so dd is never NULL.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 4b37dc69a50ce..655a7f5a406a1 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers/crypto/omap-sham.c
@@ -2197,8 +2197,7 @@ static int omap_sham_remove(struct platform_device *pdev)
 	int i, j;
 
 	dd = platform_get_drvdata(pdev);
-	if (!dd)
-		return -ENODEV;
+
 	spin_lock_bh(&sham.lock);
 	list_del(&dd->list);
 	spin_unlock_bh(&sham.lock);