From: Miklos Szeredi <mszeredi@redhat.com>
Date: Mon, 27 May 2019 09:42:07 +0000 (+0200)
Subject: fuse: fallocate: fix return with locked inode
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=35d6fcbb7c3e296a52136347346a698a35af3fda;p=linux.git

fuse: fallocate: fix return with locked inode

Do the proper cleanup in case the size check fails.

Tested with xfstests:generic/228

Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 0cbade024ba5 ("fuse: honor RLIMIT_FSIZE in fuse_file_fallocate")
Cc: Liu Bo <bo.liu@linux.alibaba.com>
Cc: <stable@vger.kernel.org> # v3.5
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 3959f08279e6f..143c54f93f2d0 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -3055,7 +3055,7 @@ static long fuse_file_fallocate(struct file *file, int mode, loff_t offset,
 	    offset + length > i_size_read(inode)) {
 		err = inode_newsize_ok(inode, offset + length);
 		if (err)
-			return err;
+			goto out;
 	}
 
 	if (!(mode & FALLOC_FL_KEEP_SIZE))