From: Amir Goldstein <amir73il@gmail.com>
Date: Sat, 17 Jun 2023 08:00:24 +0000 (+0300)
Subject: ovl: clarify ovl_get_root() semantics
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=367d002d6cd21b8f0afe710cd9276fffe7b56d69;p=linux.git

ovl: clarify ovl_get_root() semantics

Change the semantics to take a reference on upperdentry instead
of transferrig the reference.

This is needed for upcoming port to new mount api.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---

diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index ee9adb413d0e3..280f2aa2f3568 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -1922,6 +1922,8 @@ static struct dentry *ovl_get_root(struct super_block *sb,
 	ovl_set_upperdata(d_inode(root));
 	ovl_inode_init(d_inode(root), &oip, ino, fsid);
 	ovl_dentry_init_flags(root, upperdentry, oe, DCACHE_OP_WEAK_REVALIDATE);
+	/* root keeps a reference of upperdentry */
+	dget(upperdentry);
 
 	return root;
 }
@@ -2100,7 +2102,7 @@ static int ovl_fill_super(struct super_block *sb, void *data, int silent)
 	if (!root_dentry)
 		goto out_free_oe;
 
-	mntput(upperpath.mnt);
+	path_put(&upperpath);
 	kfree(splitlower);
 
 	sb->s_root = root_dentry;