From: Axel Lin Date: Fri, 21 May 2021 07:30:20 +0000 (+0800) Subject: regulator: scmi: Fix off-by-one for linear regulators .n_voltages setting X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=36cb555fae0875d5416e8514a84a427bec6e4cda;p=linux.git regulator: scmi: Fix off-by-one for linear regulators .n_voltages setting For linear regulators, the .n_voltages is (max_uv - min_uv) / uv_step + 1. Fixes: 0fbeae70ee7c ("regulator: add SCMI driver") Signed-off-by: Axel Lin Reviewed-by: Cristian Marussi Link: https://lore.kernel.org/r/20210521073020.1944981-1-axel.lin@ingics.com Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c index a917c81e99fac..51eb97815c001 100644 --- a/drivers/regulator/scmi-regulator.c +++ b/drivers/regulator/scmi-regulator.c @@ -176,7 +176,7 @@ scmi_config_linear_regulator_mappings(struct scmi_regulator *sreg, sreg->desc.uV_step = vinfo->levels_uv[SCMI_VOLTAGE_SEGMENT_STEP]; sreg->desc.linear_min_sel = 0; - sreg->desc.n_voltages = delta_uV / sreg->desc.uV_step; + sreg->desc.n_voltages = (delta_uV / sreg->desc.uV_step) + 1; sreg->desc.ops = &scmi_reg_linear_ops; }