From: Gustavo A. R. Silva <garsilva@embeddedor.com>
Date: Sat, 21 Oct 2017 03:36:52 +0000 (-0500)
Subject: can: dev: can_restart(): remove unused code
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=371fd7baa81d2adb05c390f8f8a42a4f02173cbd;p=linux.git

can: dev: can_restart(): remove unused code

Value assigned to variable err is overwritten at line
562: err = priv->do_set_mode(dev, CAN_MODE_START); before
it can be used.

Also, notice that this code has been there since 2014.

Addresses-Coverity-ID: 1227031
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---

diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
index 1c88c361938cc..6ee06a49fb4cd 100644
--- a/drivers/net/can/dev.c
+++ b/drivers/net/can/dev.c
@@ -553,10 +553,9 @@ static void can_restart(struct net_device *dev)
 
 	/* send restart message upstream */
 	skb = alloc_can_err_skb(dev, &cf);
-	if (!skb) {
-		err = -ENOMEM;
+	if (!skb)
 		goto restart;
-	}
+
 	cf->can_id |= CAN_ERR_RESTARTED;
 
 	netif_rx(skb);