From: Joaquín Ignacio Aramendía <samsagax@gmail.com>
Date: Sat, 17 Jun 2023 18:11:43 +0000 (-0300)
Subject: hwmon: (oxp-sensors) Simplify logic of error return
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=37f665ffa886ce49d1baaca1c3501ce93713b77e;p=linux.git

hwmon: (oxp-sensors) Simplify logic of error return

Take return logic on error out of if-else, eliminating
duplicated code in tt_togle_store() function.

Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
Link: https://lore.kernel.org/r/20230617181159.32844-3-samsagax@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---

diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
index 584e48d8106ec..1e59d97219c40 100644
--- a/drivers/hwmon/oxp-sensors.c
+++ b/drivers/hwmon/oxp-sensors.c
@@ -226,13 +226,12 @@ static ssize_t tt_toggle_store(struct device *dev,
 
 	if (value) {
 		rval = tt_toggle_enable();
-		if (rval)
-			return rval;
 	} else {
 		rval = tt_toggle_disable();
-		if (rval)
-			return rval;
 	}
+	if (rval)
+		return rval;
+
 	return count;
 }