From: Sebastian Andrzej Siewior Date: Fri, 1 Mar 2024 21:45:29 +0000 (+0100) Subject: serial: pch: Don't initialize uart_port's spin_lock. X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=38f3fc2e82a03d6dbb30c1fecacc630bd0ac9c28;p=linux.git serial: pch: Don't initialize uart_port's spin_lock. There is no need to directly initialize the spinlock_t in struct uart_port. The structure is later passed to uart_add_one_port() which initialize the complete struct including the lock member. Remove spin_lock_init() on uart_port's internal lock. Signed-off-by: Sebastian Andrzej Siewior Link: https://lore.kernel.org/r/20240301215246.891055-17-bigeasy@linutronix.de Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c index 6e259f4139153..3911703918764 100644 --- a/drivers/tty/serial/pch_uart.c +++ b/drivers/tty/serial/pch_uart.c @@ -1725,8 +1725,6 @@ static struct eg20t_port *pch_uart_init_port(struct pci_dev *pdev, KBUILD_MODNAME ":" PCH_UART_DRIVER_DEVICE "%d", priv->port.line); - spin_lock_init(&priv->port.lock); - pci_set_drvdata(pdev, priv); priv->trigger_level = 1; priv->fcr = 0;