From: Chuhong Yuan Date: Mon, 18 Nov 2019 11:41:15 +0000 (+0800) Subject: phy: mdio-sun4i: add missed regulator_disable in remove X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=39c68b3fc2c3c84ffdfdb867c136c5b41b29d6d0;p=linux.git phy: mdio-sun4i: add missed regulator_disable in remove The driver forgets to disable the regulator in remove like what is done in probe failure. Add the missed call to fix it. Signed-off-by: Chuhong Yuan Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/mdio-sun4i.c b/drivers/net/phy/mdio-sun4i.c index 58d6504495e01..f798de3276dce 100644 --- a/drivers/net/phy/mdio-sun4i.c +++ b/drivers/net/phy/mdio-sun4i.c @@ -145,8 +145,11 @@ err_out_free_mdiobus: static int sun4i_mdio_remove(struct platform_device *pdev) { struct mii_bus *bus = platform_get_drvdata(pdev); + struct sun4i_mdio_data *data = bus->priv; mdiobus_unregister(bus); + if (data->regulator) + regulator_disable(data->regulator); mdiobus_free(bus); return 0;