From: Peng Fan <peng.fan@nxp.com>
Date: Mon, 25 Mar 2024 17:16:26 +0000 (+0200)
Subject: gpiolib: use dev_err() when gpiod_configure_flags failed
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=39c9049770f8b5911beed49250d7c6b135685ebc;p=linux.git

gpiolib: use dev_err() when gpiod_configure_flags failed

When gpio-ranges property was missed to be added in the gpio node,
using dev_err() to show an error message will helping to locate issues
easier.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 59ccf9a3e1539..6c963a4fbc72f 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -4237,7 +4237,7 @@ struct gpio_desc *gpiod_find_and_request(struct device *consumer,
 	ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
 	if (ret < 0) {
 		gpiod_put(desc);
-		dev_dbg(consumer, "setup of GPIO %s failed\n", name);
+		dev_err(consumer, "setup of GPIO %s failed: %d\n", name, ret);
 		return ERR_PTR(ret);
 	}