From: Leon Romanovsky <leonro@mellanox.com>
Date: Sun, 24 Jun 2018 08:23:48 +0000 (+0300)
Subject: RDMA/umem: Don't check for a negative return value of dma_map_sg_attrs()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=3a2e791c9456aab38a727b2b2558c08210f59f03;p=linux.git

RDMA/umem: Don't check for a negative return value of dma_map_sg_attrs()

dma_map_sg_attrs() returns 0 on error and can't return a negative number
(ensured by BUG_ON), so don't check.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---

diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
index 54ab6335c48d2..498f59bb4989e 100644
--- a/drivers/infiniband/core/umem.c
+++ b/drivers/infiniband/core/umem.c
@@ -206,7 +206,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
 				  DMA_BIDIRECTIONAL,
 				  dma_attrs);
 
-	if (umem->nmap <= 0) {
+	if (!umem->nmap) {
 		ret = -ENOMEM;
 		goto out;
 	}