From: Kunihiko Hayashi Date: Mon, 24 Oct 2022 07:23:14 +0000 (+0900) Subject: net: ethernet: ave: Remove duplicate phy_resume() calls X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=3a6573b7a21864aafd43b347918a39e84dabfd89;p=linux.git net: ethernet: ave: Remove duplicate phy_resume() calls ave_open() in ave_resume() executes __phy_resume() via phy_start(), so no need to call phy_resume() explicitly. Remove it. Signed-off-by: Kunihiko Hayashi Link: https://lore.kernel.org/r/20221024072314.24969-1-hayashi.kunihiko@socionext.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c index 1fa09b49ba7fa..f7a44e039b5fa 100644 --- a/drivers/net/ethernet/socionext/sni_ave.c +++ b/drivers/net/ethernet/socionext/sni_ave.c @@ -1760,12 +1760,6 @@ static int ave_resume(struct device *dev) wol.wolopts = priv->wolopts; __ave_ethtool_set_wol(ndev, &wol); - if (ndev->phydev) { - ret = phy_resume(ndev->phydev); - if (ret) - return ret; - } - if (netif_running(ndev)) { ret = ave_open(ndev); netif_device_attach(ndev);