From: Marc-André Lureau Date: Tue, 17 Jul 2018 12:43:51 +0000 (+0200) Subject: char-socket: correctly set has_reconnect when parsing QemuOpts X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=3b023756b1807f4d5f91a5c2c801935c45fa9bed;p=qemu.git char-socket: correctly set has_reconnect when parsing QemuOpts qemu_chr_parse_socket() fills all ChardevSocket fields, but that doesn't reflect correctly the arguments given with the options / on the command line. "reconnect" takes a number as argument, and the default value is 0, which doesn't help to identify the missing option. The other arguments have default values that are less problematic, leave them set by default for now. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- diff --git a/chardev/char-socket.c b/chardev/char-socket.c index a75b46d9fe..64e24cb2ab 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -1117,7 +1117,7 @@ static void qemu_chr_parse_socket(QemuOpts *opts, ChardevBackend *backend, sock->tn3270 = is_tn3270; sock->has_wait = true; sock->wait = is_waitconnect; - sock->has_reconnect = true; + sock->has_reconnect = qemu_opt_find(opts, "reconnect"); sock->reconnect = reconnect; sock->tls_creds = g_strdup(tls_creds);