From: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Mon, 6 Nov 2017 18:39:19 +0000 (+0100)
Subject: tpm-emulator: add a FIXME comment about blocking cancel
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=3d01141144583bd12b5d7c76326328e509a677ec;p=qemu.git

tpm-emulator: add a FIXME comment about blocking cancel

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
---

diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c
index 94e6660a5a..24cb61162f 100644
--- a/hw/tpm/tpm_emulator.c
+++ b/hw/tpm/tpm_emulator.c
@@ -338,6 +338,7 @@ static void tpm_emulator_cancel_cmd(TPMBackend *tb)
         return;
     }
 
+    /* FIXME: make the function non-blocking, or it may block a VCPU */
     if (tpm_emulator_ctrlcmd(tpm_emu, CMD_CANCEL_TPM_CMD, &res, 0,
                              sizeof(res)) < 0) {
         error_report("tpm-emulator: Could not cancel command: %s",