From: Colin Ian King <colin.king@canonical.com>
Date: Fri, 8 Dec 2017 15:13:29 +0000 (+0000)
Subject: security: keys: remove redundant assignment to key_ref
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=3d1f0255426af7eeb88bf7221ff683b7ca9e4493;p=linux.git

security: keys: remove redundant assignment to key_ref

Variable key_ref is being assigned a value that is never read;
key_ref is being re-assigned a few statements later.  Hence this
assignment is redundant and can be removed.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: James Morris <james.l.morris@oracle.com>
---

diff --git a/security/keys/key.c b/security/keys/key.c
index 66049183ad896..d97c9394b5dd4 100644
--- a/security/keys/key.c
+++ b/security/keys/key.c
@@ -833,7 +833,6 @@ key_ref_t key_create_or_update(key_ref_t keyring_ref,
 
 	key_check(keyring);
 
-	key_ref = ERR_PTR(-EPERM);
 	if (!(flags & KEY_ALLOC_BYPASS_RESTRICTION))
 		restrict_link = keyring->restrict_link;