From: Paul E. McKenney <paulmck@linux.ibm.com>
Date: Sun, 11 Nov 2018 18:49:10 +0000 (-0800)
Subject: checkpatch.pl: Suggest lockdep instead of asserting !spin_is_locked()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=3d709ab5a1767d422223e84cf5c20f0d33738274;p=linux.git

checkpatch.pl: Suggest lockdep instead of asserting !spin_is_locked()

This commit points people who might otherwise code up something like
WARN_ON(!spin_is_locked(&mylock)) to lockdep_assert_held(&mylock).

Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
---

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index dd29e3c281667..377f373db6c00 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6389,6 +6389,12 @@ sub process {
 			     "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
 		}
 
+# check for spin_is_locked(), suggest lockdep instead
+		if ($line =~ /\bspin_is_locked\(/) {
+			WARN("USE_LOCKDEP",
+			     "Where possible, use lockdep_assert_held instead of assertions based on spin_is_locked\n" . $herecurr);
+		}
+
 # check for deprecated apis
 		if ($line =~ /\b($deprecated_apis_search)\b\s*\(/) {
 			my $deprecated_api = $1;