From: Uwe Kleine-König Date: Mon, 5 Jun 2023 09:20:46 +0000 (+0200) Subject: char: xilinx_hwicap: Drop if block with always false condition X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=3d82dca0f27ac5a0bfbbce439bba5c6452f3b7da;p=linux.git char: xilinx_hwicap: Drop if block with always false condition hwicap_drv_remove() is only called for a device after hwicap_drv_probe() returned 0. In that case dev_set_drvdata() was called (by hwicap_setup()) with a non-NULL value and so dev_get_drvdata() won't return NULL. Signed-off-by: Uwe Kleine-König Acked-by: Michal Simek Message-ID: <20230605092047.50472-2-u.kleine-koenig@pengutronix.de> Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xilinx_hwicap/xilinx_hwicap.c index c4d75e684be66..87ece300b2caa 100644 --- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c @@ -810,8 +810,6 @@ static int hwicap_drv_remove(struct platform_device *pdev) struct hwicap_drvdata *drvdata; drvdata = dev_get_drvdata(dev); - if (!drvdata) - return 0; device_destroy(icap_class, drvdata->devt); cdev_del(&drvdata->cdev);