From: Karina Yankevich Date: Fri, 22 Sep 2023 13:59:25 +0000 (+0300) Subject: pinctrl: mediatek: paris: handle mtk_hw_set_value() errors in mtk_pmx_set_mux() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=3d855c3f2e1373f40962ea4ab7b97c6a563b52bc;p=linux.git pinctrl: mediatek: paris: handle mtk_hw_set_value() errors in mtk_pmx_set_mux() mtk_pmx_set_mux() doesn't check the result of mtk_hw_set_value() despite it may return negative error code. Propagate error code to caller functions. Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. Signed-off-by: Karina Yankevich Link: https://lore.kernel.org/r/20230922135926.3653428-1-k.yankevich@omp.ru Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c index 33d6c3fb79080..b7cb5a1f1060f 100644 --- a/drivers/pinctrl/mediatek/pinctrl-paris.c +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c @@ -779,9 +779,7 @@ static int mtk_pmx_set_mux(struct pinctrl_dev *pctldev, return -EINVAL; desc = (const struct mtk_pin_desc *)&hw->soc->pins[grp->pin]; - mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_MODE, desc_func->muxval); - - return 0; + return mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_MODE, desc_func->muxval); } static const struct pinmux_ops mtk_pmxops = {