From: Peter Maydell Date: Sat, 21 Nov 2020 21:03:42 +0000 (+0000) Subject: gdbstub: Correct misparsing of vCont C/S requests X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=3ddd9036389f5f577e09e1d2f54f8c384660b5ef;p=qemu.git gdbstub: Correct misparsing of vCont C/S requests In the vCont packet, two of the command actions (C and S) take an argument specifying the signal to be sent to the process/thread, which is sent as an ASCII string of two hex digits which immediately follow the 'C' or 'S' character. Our code for parsing this packet accidentally skipped the first of the two bytes of the signal value, because it started parsing the hex string at 'p + 1' when the preceding code had already moved past the 'C' or 'S' with "cur_action = *p++". This meant that we would only do the right thing for signals below 10, and would misinterpret the rest. For instance, when the debugger wants to send the process a SIGPROF (27 on x86-64) we mangle this into a SIGSEGV (11). Remove the accidental double increment. Fixes: https://bugs.launchpad.net/qemu/+bug/1773743 Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-id: 20201121210342.10089-1-peter.maydell@linaro.org --- diff --git a/gdbstub.c b/gdbstub.c index f19f98ab1a..d99bc0bf2e 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1243,7 +1243,7 @@ static int gdb_handle_vcont(const char *p) cur_action = *p++; if (cur_action == 'C' || cur_action == 'S') { cur_action = qemu_tolower(cur_action); - res = qemu_strtoul(p + 1, &p, 16, &tmp); + res = qemu_strtoul(p, &p, 16, &tmp); if (res) { goto out; }