From: Philippe Mathieu-Daudé <philmd@redhat.com>
Date: Thu, 2 Sep 2021 07:00:18 +0000 (+0200)
Subject: util/vfio-helpers: Remove unreachable code in qemu_vfio_dma_map()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=3f4c0affcfbc7c1da0b117bee0cd5be6f52fa3e5;p=qemu.git

util/vfio-helpers: Remove unreachable code in qemu_vfio_dma_map()

qemu_vfio_add_mapping() returns a pointer to an indexed entry
in pre-allocated QEMUVFIOState::mappings[], thus can not be NULL.
Remove the pointless check.

Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20210902070025.197072-5-philmd@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---

diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c
index d956866b4e..e7909222cf 100644
--- a/util/vfio-helpers.c
+++ b/util/vfio-helpers.c
@@ -751,10 +751,6 @@ int qemu_vfio_dma_map(QEMUVFIOState *s, void *host, size_t size,
             }
 
             mapping = qemu_vfio_add_mapping(s, host, size, index + 1, iova0);
-            if (!mapping) {
-                ret = -ENOMEM;
-                goto out;
-            }
             assert(qemu_vfio_verify_mappings(s));
             ret = qemu_vfio_do_mapping(s, host, size, iova0);
             if (ret) {