From: Jim Meyering <meyering@redhat.com>
Date: Wed, 22 Aug 2012 11:55:52 +0000 (+0200)
Subject: qemu-ga: don't leak a file descriptor upon failed lockf
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4144f122b477164cf466ca69be24cf4ef5c218d3;p=qemu.git

qemu-ga: don't leak a file descriptor upon failed lockf

Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---

diff --git a/qemu-ga.c b/qemu-ga.c
index 8f87621ae4..26671fee3f 100644
--- a/qemu-ga.c
+++ b/qemu-ga.c
@@ -247,6 +247,9 @@ static bool ga_open_pidfile(const char *pidfile)
     pidfd = open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
     if (pidfd == -1 || lockf(pidfd, F_TLOCK, 0)) {
         g_critical("Cannot lock pid file, %s", strerror(errno));
+        if (pidfd != -1) {
+            close(pidfd);
+        }
         return false;
     }