From: Christian Brauner <christian@brauner.io>
Date: Mon, 21 Jan 2019 10:48:06 +0000 (+0100)
Subject: binderfs: kill_litter_super() before cleanup
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4198479524aeccaf53c3a4cc73784982535573fa;p=linux.git

binderfs: kill_litter_super() before cleanup

Al pointed out that first calling kill_litter_super() before cleaning up
info is more correct since destroying info doesn't depend on the state of
the dentries and inodes. That the opposite remains true is not guaranteed.

Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Christian Brauner <christian@brauner.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
index 1e077498a5070..ba88be172aeee 100644
--- a/drivers/android/binderfs.c
+++ b/drivers/android/binderfs.c
@@ -531,11 +531,12 @@ static void binderfs_kill_super(struct super_block *sb)
 {
 	struct binderfs_info *info = sb->s_fs_info;
 
+	kill_litter_super(sb);
+
 	if (info && info->ipc_ns)
 		put_ipc_ns(info->ipc_ns);
 
 	kfree(info);
-	kill_litter_super(sb);
 }
 
 static struct file_system_type binder_fs_type = {