From: Ilya Dryomov <idryomov@gmail.com>
Date: Sat, 13 Oct 2018 09:36:52 +0000 (+0200)
Subject: libceph: no need to call osd_req_opcode_valid() in osd_req_encode_op()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=41a264e1b30ccde9ac83a314559ddacb78a85e91;p=linux.git

libceph: no need to call osd_req_opcode_valid() in osd_req_encode_op()

Any uninitialized or unknown ops will be caught by the default clause
anyway.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---

diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index ad00495dbd392..f403a483d51d2 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -903,12 +903,6 @@ static void ceph_osdc_msg_data_add(struct ceph_msg *msg,
 static u32 osd_req_encode_op(struct ceph_osd_op *dst,
 			     const struct ceph_osd_req_op *src)
 {
-	if (WARN_ON(!osd_req_opcode_valid(src->op))) {
-		pr_err("unrecognized osd opcode %d\n", src->op);
-
-		return 0;
-	}
-
 	switch (src->op) {
 	case CEPH_OSD_OP_STAT:
 		break;