From: Peter Crosthwaite Date: Mon, 3 Jun 2013 05:32:42 +0000 (+1000) Subject: memory: as_update_topology_pass: Improve comments X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=41a6e477fda3e3e5c8cc860458d29164625dc5e0;p=qemu.git memory: as_update_topology_pass: Improve comments These comments were a little difficult to read. First one had incorrect parenthesis. The part about attributes changing is really applicable to the region being 'in both' rather than 'in new' Second comment has an obscure parenthetic about 'Logging may have changed'. Made clearer, as this if is supposed to handle the case where the memory region is unchanged (with the notable exception re logging). Signed-off-by: Peter Crosthwaite Signed-off-by: Paolo Bonzini --- diff --git a/memory.c b/memory.c index 221b725e8f..0e07d0f4cd 100644 --- a/memory.c +++ b/memory.c @@ -719,7 +719,7 @@ static void address_space_update_topology_pass(AddressSpace *as, || int128_lt(frold->addr.start, frnew->addr.start) || (int128_eq(frold->addr.start, frnew->addr.start) && !flatrange_equal(frold, frnew)))) { - /* In old, but (not in new, or in new but attributes changed). */ + /* In old but not in new, or in both but attributes changed. */ if (!adding) { MEMORY_LISTENER_UPDATE_REGION(frold, as, Reverse, region_del); @@ -727,7 +727,7 @@ static void address_space_update_topology_pass(AddressSpace *as, ++iold; } else if (frold && frnew && flatrange_equal(frold, frnew)) { - /* In both (logging may have changed) */ + /* In both and unchanged (except logging may have changed) */ if (adding) { MEMORY_LISTENER_UPDATE_REGION(frnew, as, Forward, region_nop);