From: Nicholas Mc Guire Date: Sat, 1 Dec 2018 12:44:29 +0000 (+0100) Subject: Documentation: devres: note checking needs when converting X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=41c31f6a5945a4b005302e01d47c97bcf5d604ac;p=linux.git Documentation: devres: note checking needs when converting There are a number of cases where conversions to devm_* API have been done but developers forgot that this conversion may imply that return values need to be checked for failure of internal resource handling like allocation. While this should be clear, it does seem to be a relatively common issue with API conversions or maybe "managed" is being misunderstood ? So add a note to make the scope of "managed" clear. Signed-off-by: Nicholas Mc Guire Signed-off-by: Jonathan Corbet --- diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt index 43681ca0837f8..f106c49c849d1 100644 --- a/Documentation/driver-model/devres.txt +++ b/Documentation/driver-model/devres.txt @@ -132,6 +132,13 @@ devres. Complexity is shifted from less maintained low level drivers to better maintained higher layer. Also, as init failure path is shared with exit path, both can get more testing. +Note though that when converting current calls or assignments to +managed devm_* versions it is up to you to check if internal operations +like allocating memory, have failed. Managed resources pertains to the +freeing of these resources *only* - all other checks needed are still +on you. In some cases this may mean introducing checks that were not +necessary before moving to the managed devm_* calls. + 3. Devres group ---------------