From: Li Qiang Date: Tue, 1 Nov 2016 09:53:11 +0000 (-0700) Subject: virtio-gpu: fix information leak in getting capset info dispatch X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=42a8dadc74f8982fc269e54e3c5627b54d9f83d8;p=qemu.git virtio-gpu: fix information leak in getting capset info dispatch In virgl_cmd_get_capset_info dispatch function, the 'resp' hasn't been full initialized before writing to the guest. This will leak the 'resp.padding' and 'resp.hdr.padding' fieds to the guest. This patch fix this issue. Signed-off-by: Li Qiang Message-id: 5818661e.0860240a.77264.7a56@mx.google.com Reviewed-by: Marc-André Lureau Signed-off-by: Gerd Hoffmann --- diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c index 758d33a09d..23f39de94d 100644 --- a/hw/display/virtio-gpu-3d.c +++ b/hw/display/virtio-gpu-3d.c @@ -347,6 +347,7 @@ static void virgl_cmd_get_capset_info(VirtIOGPU *g, VIRTIO_GPU_FILL_CMD(info); + memset(&resp, 0, sizeof(resp)); if (info.capset_index == 0) { resp.capset_id = VIRTIO_GPU_CAPSET_VIRGL; virgl_renderer_get_cap_set(resp.capset_id,