From: Oded Gabbay Date: Tue, 26 Feb 2019 09:23:34 +0000 (+0200) Subject: habanalabs: return error when failing to read/write i2c X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4398e7057d66050b4121b97da048bfe3fdaf4c8d;p=linux.git habanalabs: return error when failing to read/write i2c The driver can't read/write from i2c if the device is in reset or disabled. Therefore, return -EBUSY in those cases instead of 0. This change also fixes a smatch warning about uninitialized variable. Reported-by: Dan Carpenter Signed-off-by: Oded Gabbay Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/habanalabs/debugfs.c b/drivers/misc/habanalabs/debugfs.c index a6d9d809385e9..f472b572faea5 100644 --- a/drivers/misc/habanalabs/debugfs.c +++ b/drivers/misc/habanalabs/debugfs.c @@ -25,7 +25,7 @@ static int hl_debugfs_i2c_read(struct hl_device *hdev, u8 i2c_bus, u8 i2c_addr, int rc; if (hl_device_disabled_or_in_reset(hdev)) - return 0; + return -EBUSY; memset(&pkt, 0, sizeof(pkt)); @@ -50,7 +50,7 @@ static int hl_debugfs_i2c_write(struct hl_device *hdev, u8 i2c_bus, u8 i2c_addr, int rc; if (hl_device_disabled_or_in_reset(hdev)) - return 0; + return -EBUSY; memset(&pkt, 0, sizeof(pkt));