From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Tue, 28 Jan 2020 21:32:13 +0000 (+0200)
Subject: platform/x86: dell_rbu: Simplify cleanup code in create_packet()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=45e21277f94753c3e3429e63e5785888ee1ead4a;p=linux.git

platform/x86: dell_rbu: Simplify cleanup code in create_packet()

The code looks more nicer if we use:
	while (idx--)
instead:
	for (;idx>0;idx--)

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

diff --git a/drivers/platform/x86/dell_rbu.c b/drivers/platform/x86/dell_rbu.c
index 4e044fc60b1e6..416a7db9966af 100644
--- a/drivers/platform/x86/dell_rbu.c
+++ b/drivers/platform/x86/dell_rbu.c
@@ -199,12 +199,10 @@ static int create_packet(void *data, size_t length)
 
 out_alloc_packet_array:
 	/* always free packet array */
-	for (;idx>0;idx--) {
+	while (idx--) {
 		pr_debug("freeing unused packet below floor 0x%lx.\n",
-			(unsigned long)virt_to_phys(
-				invalid_addr_packet_array[idx-1]));
-		free_pages((unsigned long)invalid_addr_packet_array[idx-1],
-			ordernum);
+			(unsigned long)virt_to_phys(invalid_addr_packet_array[idx]));
+		free_pages((unsigned long)invalid_addr_packet_array[idx], ordernum);
 	}
 	kfree(invalid_addr_packet_array);