From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 16 Mar 2022 12:23:54 +0000 (+0300)
Subject: iio: dac: ad3552r: fix signedness bug in ad3552r_reset()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=460bfa65b0de72f4d8a808bc7cfb1cb591a95b18;p=linux.git

iio: dac: ad3552r: fix signedness bug in ad3552r_reset()

The "val" variable is used to store either negative error codes from
ad3552r_read_reg_wrapper() or positive u16 values on success.  It needs
to be signed for the error handling to work correctly.

Fixes: 8f2b54824b28 ("drivers:iio:dac: Add AD3552R driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220316122354.GA16825@kili
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---

diff --git a/drivers/iio/dac/ad3552r.c b/drivers/iio/dac/ad3552r.c
index 97f13c0b96312..e0a93b27e0e81 100644
--- a/drivers/iio/dac/ad3552r.c
+++ b/drivers/iio/dac/ad3552r.c
@@ -656,7 +656,7 @@ static int ad3552r_reset(struct ad3552r_desc *dac)
 {
 	struct reg_addr_pool addr;
 	int ret;
-	u16 val;
+	int val;
 
 	dac->gpio_reset = devm_gpiod_get_optional(&dac->spi->dev, "reset",
 						  GPIOD_OUT_LOW);