From: Hermes Zhang Date: Tue, 10 Jan 2023 02:47:46 +0000 (+0800) Subject: power: supply: bq256xx: Init ichg/vbat value with chip default value X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4651b6b72934e602202def29c88813d95716f7c7;p=linux.git power: supply: bq256xx: Init ichg/vbat value with chip default value Init the ichg/vbat reg with chip default value instead of the max value used now. The max value set in driver will result an unsafe case (e.g. battery is over charging when in a hot environment) if no user space update the value later. Signed-off-by: Hermes Zhang Signed-off-by: Sebastian Reichel --- diff --git a/drivers/power/supply/bq256xx_charger.c b/drivers/power/supply/bq256xx_charger.c index db13e288e439a..9cf4936440c93 100644 --- a/drivers/power/supply/bq256xx_charger.c +++ b/drivers/power/supply/bq256xx_charger.c @@ -1563,7 +1563,7 @@ static int bq256xx_hw_init(struct bq256xx_device *bq) return ret; ret = bq->chip_info->bq256xx_set_ichg(bq, - bat_info->constant_charge_current_max_ua); + bq->chip_info->bq256xx_def_ichg); if (ret) return ret; @@ -1573,7 +1573,7 @@ static int bq256xx_hw_init(struct bq256xx_device *bq) return ret; ret = bq->chip_info->bq256xx_set_vbatreg(bq, - bat_info->constant_charge_voltage_max_uv); + bq->chip_info->bq256xx_def_vbatreg); if (ret) return ret;