From: yzhai003@ucr.edu Date: Fri, 1 Jun 2018 18:30:14 +0000 (-0700) Subject: iommu/amd: Argument page_size could be uninitialized X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4674686d6c8974eb4eebec894c398a0f6c506af3;p=linux.git iommu/amd: Argument page_size could be uninitialized Argument "page_size" passing to function "fetch_pte" could be uninitialized if the function returns NULL The caller "iommu_unmap_page" checks the return value but the page_size is used outside the if block. Signed-off-by: yzhai003@ucr.edu Signed-off-by: Joerg Roedel --- diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index 596b95c50051d..e688169721b88 100644 --- a/drivers/iommu/amd_iommu.c +++ b/drivers/iommu/amd_iommu.c @@ -1404,6 +1404,8 @@ static u64 *fetch_pte(struct protection_domain *domain, int level; u64 *pte; + *page_size = 0; + if (address > PM_LEVEL_SIZE(domain->mode)) return NULL;