From: Dan Carpenter Date: Fri, 4 Mar 2022 13:12:56 +0000 (+0300) Subject: ASoC: amd: vg: fix signedness bug in acp5x_audio_probe() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=468f252930d8fda0e4365b788b4b621fe59c05ce;p=linux.git ASoC: amd: vg: fix signedness bug in acp5x_audio_probe() The "adata->i2s_irq" variable is unsigned so the error handling will not work. Fixes: 87d71a128771 ("ASoC: amd: pcm-dma: Use platform_get_irq() to get the interrupt") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20220304131256.GA28739@kili Signed-off-by: Mark Brown --- diff --git a/sound/soc/amd/vangogh/acp5x-pcm-dma.c b/sound/soc/amd/vangogh/acp5x-pcm-dma.c index e4e668593b3d1..31fa166df98ac 100644 --- a/sound/soc/amd/vangogh/acp5x-pcm-dma.c +++ b/sound/soc/amd/vangogh/acp5x-pcm-dma.c @@ -388,9 +388,10 @@ static int acp5x_audio_probe(struct platform_device *pdev) if (!adata->acp5x_base) return -ENOMEM; - adata->i2s_irq = platform_get_irq(pdev, 0); - if (adata->i2s_irq < 0) - return -ENODEV; + status = platform_get_irq(pdev, 0); + if (status < 0) + return status; + adata->i2s_irq = status; dev_set_drvdata(&pdev->dev, adata); status = devm_snd_soc_register_component(&pdev->dev,