From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 27 Aug 2019 10:59:17 +0000 (+0300)
Subject: cifs: Use kzfree() to zero out the password
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=478228e57f81f6cb60798d54fc02a74ea7dd267e;p=linux.git

cifs: Use kzfree() to zero out the password

It's safer to zero out the password so that it can never be disclosed.

Fixes: 0c219f5799c7 ("cifs: set domainName when a domain-key is used in multiuser")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 9d2576f316895..ddefddeffd064 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -3101,7 +3101,7 @@ cifs_set_cifscreds(struct smb_vol *vol, struct cifs_ses *ses)
 			rc = -ENOMEM;
 			kfree(vol->username);
 			vol->username = NULL;
-			kfree(vol->password);
+			kzfree(vol->password);
 			vol->password = NULL;
 			goto out_key_put;
 		}