From: NeilBrown Date: Wed, 13 Dec 2017 03:15:54 +0000 (+1100) Subject: staging: lustre: lov: use list_for_each_entry in lov_obd.c X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=47d59e75e9c7d0873171557348bbc5c28548b466;p=linux.git staging: lustre: lov: use list_for_each_entry in lov_obd.c Using the *_entry macro simplifies the code slightly. Signed-off-by: NeilBrown Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c b/drivers/staging/lustre/lustre/lov/lov_obd.c index 7ce01026a4093..ec70c12e5b40d 100644 --- a/drivers/staging/lustre/lustre/lov/lov_obd.c +++ b/drivers/staging/lustre/lustre/lov/lov_obd.c @@ -828,11 +828,9 @@ out: static int lov_cleanup(struct obd_device *obd) { struct lov_obd *lov = &obd->u.lov; - struct list_head *pos, *tmp; - struct pool_desc *pool; + struct pool_desc *pool, *tmp; - list_for_each_safe(pos, tmp, &lov->lov_pool_list) { - pool = list_entry(pos, struct pool_desc, pool_list); + list_for_each_entry_safe(pool, tmp, &lov->lov_pool_list, pool_list) { /* free pool structs */ CDEBUG(D_INFO, "delete pool %p\n", pool); /* In the function below, .hs_keycmp resolves to