From: Gustavo A. R. Silva Date: Wed, 16 Dec 2020 04:43:07 +0000 (-0800) Subject: lib/stackdepot.c: use flex_array_size() helper in memcpy() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=47e684aaa2661b2af39474a12d05447865ce9184;p=linux.git lib/stackdepot.c: use flex_array_size() helper in memcpy() Make use of the flex_array_size() helper to calculate the size of a flexible array member within an enclosing structure. This helper offers defense-in-depth against potential integer overflows, while at the same time makes it explicitly clear that we are dealing with a flexible array member. Link: https://lkml.kernel.org/r/186e37fe07196ee41a0e562fa8a8cb7a01112ec5.1601565471.git.gustavoars@kernel.org Signed-off-by: Gustavo A. R. Silva Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/lib/stackdepot.c b/lib/stackdepot.c index c6106cfb79501..683b6a8ddade1 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -135,7 +135,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size, stack->handle.slabindex = depot_index; stack->handle.offset = depot_offset >> STACK_ALLOC_ALIGN; stack->handle.valid = 1; - memcpy(stack->entries, entries, size * sizeof(unsigned long)); + memcpy(stack->entries, entries, flex_array_size(stack, entries, size)); depot_offset += required_size; return stack;