From: Viresh Kumar Date: Tue, 20 Oct 2020 10:33:15 +0000 (+0530) Subject: opp: Fix early exit from dev_pm_opp_register_set_opp_helper() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=47efcbcb340cca5d3b3d515964f09e1fec599a29;p=linux.git opp: Fix early exit from dev_pm_opp_register_set_opp_helper() We returned earlier by mistake even when there were no failures. Fix it. Fixes: dd461cd9183f ("opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER") Reported-by: Naresh Kamboju Signed-off-by: Viresh Kumar Tested-by: Naresh Kamboju --- diff --git a/drivers/opp/core.c b/drivers/opp/core.c index 2483e765318a3..4ac4e7ce6b8b2 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -1930,7 +1930,7 @@ struct opp_table *dev_pm_opp_register_set_opp_helper(struct device *dev, return ERR_PTR(-EINVAL); opp_table = dev_pm_opp_get_opp_table(dev); - if (!IS_ERR(opp_table)) + if (IS_ERR(opp_table)) return opp_table; /* This should be called before OPPs are initialized */