From: Pali Rohár Date: Thu, 25 Nov 2021 12:45:53 +0000 (+0100) Subject: PCI: mvebu: Check that PCI bridge specified in DT has function number zero X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=489bfc51870b96cd3ad2ef63cf443b5f5d1a8e21;p=linux.git PCI: mvebu: Check that PCI bridge specified in DT has function number zero Driver cannot handle PCI bridges at non-zero function address. So add appropriate check. Currently all in-tree kernel DTS files set PCI bridge function to zero. Link: https://lore.kernel.org/r/20211125124605.25915-4-pali@kernel.org Signed-off-by: Pali Rohár Signed-off-by: Lorenzo Pieralisi --- diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c index e4424db808fe9..2a2100c2e65d5 100644 --- a/drivers/pci/controller/pci-mvebu.c +++ b/drivers/pci/controller/pci-mvebu.c @@ -845,6 +845,11 @@ static int mvebu_pcie_parse_port(struct mvebu_pcie *pcie, port->devfn = of_pci_get_devfn(child); if (port->devfn < 0) goto skip; + if (PCI_FUNC(port->devfn) != 0) { + dev_err(dev, "%s: invalid function number, must be zero\n", + port->name); + goto skip; + } ret = mvebu_get_tgt_attr(dev->of_node, port->devfn, IORESOURCE_MEM, &port->mem_target, &port->mem_attr);