From: Eric Dumazet <edumazet@google.com>
Date: Thu, 21 Nov 2019 03:19:07 +0000 (-0800)
Subject: net-sysfs: fix netdev_queue_add_kobject() breakage
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=48a322b6f9965b2f1e4ce81af972f0e287b07ed0;p=linux.git

net-sysfs: fix netdev_queue_add_kobject() breakage

kobject_put() should only be called in error path.

Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jouni Hogander <jouni.hogander@unikie.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 4f404bf33e44c..ae3bcb1540ec5 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -1474,6 +1474,7 @@ static int netdev_queue_add_kobject(struct net_device *dev, int index)
 #endif
 
 	kobject_uevent(kobj, KOBJ_ADD);
+	return 0;
 
 err:
 	kobject_put(kobj);