From: Namjae Jeon Date: Tue, 21 Mar 2023 06:36:40 +0000 (+0900) Subject: ksmbd: return STATUS_NOT_SUPPORTED on unsupported smb2.0 dialect X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=496e186bc005fa4a4d9cf14e0662ae00b60e1362;p=linux.git ksmbd: return STATUS_NOT_SUPPORTED on unsupported smb2.0 dialect commit b53e8cfec30b93c120623232ba27c041b1ef8f1a upstream. ksmbd returned "Input/output error" when mounting with vers=2.0 to ksmbd. It should return STATUS_NOT_SUPPORTED on unsupported smb2.0 dialect. Cc: stable@vger.kernel.org Reported-by: Steve French Signed-off-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/ksmbd/smb_common.c b/fs/ksmbd/smb_common.c index 22f460984742f..7fbd3b9c48977 100644 --- a/fs/ksmbd/smb_common.c +++ b/fs/ksmbd/smb_common.c @@ -434,7 +434,7 @@ int ksmbd_extract_shortname(struct ksmbd_conn *conn, const char *longname, static int __smb2_negotiate(struct ksmbd_conn *conn) { - return (conn->dialect >= SMB21_PROT_ID && + return (conn->dialect >= SMB20_PROT_ID && conn->dialect <= SMB311_PROT_ID); } @@ -464,7 +464,7 @@ int ksmbd_smb_negotiate_common(struct ksmbd_work *work, unsigned int command) } } - if (command == SMB2_NEGOTIATE_HE && __smb2_negotiate(conn)) { + if (command == SMB2_NEGOTIATE_HE) { ret = smb2_handle_negotiate(work); init_smb2_neg_rsp(work); return ret;