From: YueHaibing Date: Thu, 16 Jan 2020 14:14:33 +0000 (+0800) Subject: usb: gadget: xudc: Remove redundant platform_get_irq error message X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=49f1997ad2e2e2d05917146e94dcb0ad600b866a;p=linux.git usb: gadget: xudc: Remove redundant platform_get_irq error message platform_get_irq() will call dev_err() itself on failure, so there is no need for the driver to also do this. This is detected by coccinelle. Acked-by: Thierry Reding Reviewed-by: Nagarjuna Kristam Signed-off-by: YueHaibing Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c index 634c2c19a176a..fc1eafc60cd70 100644 --- a/drivers/usb/gadget/udc/tegra-xudc.c +++ b/drivers/usb/gadget/udc/tegra-xudc.c @@ -3492,11 +3492,8 @@ static int tegra_xudc_probe(struct platform_device *pdev) } xudc->irq = platform_get_irq(pdev, 0); - if (xudc->irq < 0) { - dev_err(xudc->dev, "failed to get IRQ: %d\n", - xudc->irq); + if (xudc->irq < 0) return xudc->irq; - } err = devm_request_irq(&pdev->dev, xudc->irq, tegra_xudc_irq, 0, dev_name(&pdev->dev), xudc);