From: Wei Yang Date: Tue, 7 Apr 2020 03:04:09 +0000 (-0700) Subject: mm/migrate.c: no need to check for i > start in do_pages_move() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4afdacec2e313509bf9c25f3370be299a0d60b9a;p=linux.git mm/migrate.c: no need to check for i > start in do_pages_move() Patch series "cleanup on do_pages_move()", v5. The logic in do_pages_move() is a little mess for audience to read and has some potential error on handling the return value. Especially there are three calls on do_move_pages_to_node() and store_status() with almost the same form. This patch set tries to make the code a little friendly for audience by consolidate the calls. This patch (of 4): At this point, we always have i >= start. If i == start, store_status() will return 0. So we can drop the check for i > start. [david@redhat.com rephrase changelog] Signed-off-by: Wei Yang Signed-off-by: Andrew Morton Reviewed-by: David Hildenbrand Acked-by: Michal Hocko Link: http://lkml.kernel.org/r/20200214003017.25558-2-richardw.yang@linux.intel.com Signed-off-by: Linus Torvalds --- diff --git a/mm/migrate.c b/mm/migrate.c index 7ded07081be9a..20bc562f499e1 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1694,11 +1694,9 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, err += nr_pages - i - 1; goto out; } - if (i > start) { - err = store_status(status, start, current_node, i - start); - if (err) - goto out; - } + err = store_status(status, start, current_node, i - start); + if (err) + goto out; current_node = NUMA_NO_NODE; } out_flush: