From: Zhengchao Shao <shaozhengchao@huawei.com>
Date: Wed, 31 Aug 2022 04:14:52 +0000 (+0800)
Subject: net: sched: gred: remove NULL check before free table->tab in gred_destroy()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4bf8594a8036f42ca7ece1bbdaf45b7954fb09e6;p=linux.git

net: sched: gred: remove NULL check before free table->tab in gred_destroy()

The kfree invoked by gred_destroy_vq checks whether the input parameter
is empty. Therefore, gred_destroy() doesn't need to check table->tab.

Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Link: https://lore.kernel.org/r/20220831041452.33026-1-shaozhengchao@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---

diff --git a/net/sched/sch_gred.c b/net/sched/sch_gred.c
index 44af3b18eed90..a661b062cca85 100644
--- a/net/sched/sch_gred.c
+++ b/net/sched/sch_gred.c
@@ -908,10 +908,9 @@ static void gred_destroy(struct Qdisc *sch)
 	struct gred_sched *table = qdisc_priv(sch);
 	int i;
 
-	for (i = 0; i < table->DPs; i++) {
-		if (table->tab[i])
-			gred_destroy_vq(table->tab[i]);
-	}
+	for (i = 0; i < table->DPs; i++)
+		gred_destroy_vq(table->tab[i]);
+
 	gred_offload(sch, TC_GRED_DESTROY);
 	kfree(table->opt);
 }