From: Fam Zheng Date: Mon, 16 Feb 2015 04:09:40 +0000 (+0800) Subject: virtio-blk: Remove the stale FIXME comment X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4c0542ea60d21b56a9157d3f6331d2df8990d3bb;p=qemu.git virtio-blk: Remove the stale FIXME comment By default, we have ioeventfd enabled, so the IO request processing is in IO thread; in the vcpu thread, guest mode is returned to as quickly as possible, and completion is delivered via irqfd. Therefore this comment from the initial implementation is barely relevant. Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 2acfef87eb..0468297688 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -597,12 +597,6 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq) if (mrb.num_reqs) { virtio_blk_submit_multireq(s->blk, &mrb); } - - /* - * FIXME: Want to check for completions before returning to guest mode, - * so cached reads and writes are reported as quickly as possible. But - * that should be done in the generic block layer. - */ } static void virtio_blk_dma_restart_bh(void *opaque)