From: Linus Lüssing Date: Sun, 16 May 2021 22:33:08 +0000 (+0200) Subject: batman-adv: bcast: avoid skb-copy for (re)queued broadcasts X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4cbf055002c53c364d1b3275792e4487af76dd2d;p=linux.git batman-adv: bcast: avoid skb-copy for (re)queued broadcasts Broadcast packets send via batadv_send_outstanding_bcast_packet() were originally copied in batadv_forw_bcast_packet_to_list() before being queued. And after that only the ethernet header will be pushed through batadv_send_broadcast_skb()->batadv_send_skb_packet() which works safely on skb clones as it uses batadv_skb_head_push()->skb_cow_head(). Signed-off-by: Linus Lüssing Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c index 07b0ba2654722..0b9dd29d3b6a8 100644 --- a/net/batman-adv/send.c +++ b/net/batman-adv/send.c @@ -1072,7 +1072,7 @@ static void batadv_send_outstanding_bcast_packet(struct work_struct *work) } /* send a copy of the saved skb */ - skb1 = skb_copy(forw_packet->skb, GFP_ATOMIC); + skb1 = skb_clone(forw_packet->skb, GFP_ATOMIC); if (!skb1) goto out;