From: Binyi Han Date: Wed, 13 Jul 2022 08:00:23 +0000 (-0700) Subject: staging: qlge: Avoid multiplication while keep the same logic X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4cdb845db3217091737159908fcba1f643d818a1;p=linux.git staging: qlge: Avoid multiplication while keep the same logic Avoid the more expensive multiplication while keep the same logic. Signed-off-by: Binyi Han Link: https://lore.kernel.org/r/31fe21bf4a9e8f13cf27bd50073e9d5d197654ea.1657697683.git.dantengknight@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index 5209456edc392..4b166c66cfc58 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -3009,9 +3009,10 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring for (page_entries = 0; page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); - page_entries++) - base_indirect_ptr[page_entries] = - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE)); + page_entries++) { + base_indirect_ptr[page_entries] = cpu_to_le64(tmp); + tmp += DB_PAGE_SIZE; + } cqicb->lbq_addr = cpu_to_le64(rx_ring->lbq.base_indirect_dma); cqicb->lbq_buf_size = cpu_to_le16(QLGE_FIT16(qdev->lbq_buf_size)); @@ -3025,9 +3026,10 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring for (page_entries = 0; page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); - page_entries++) - base_indirect_ptr[page_entries] = - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE)); + page_entries++) { + base_indirect_ptr[page_entries] = cpu_to_le64(tmp); + tmp += DB_PAGE_SIZE; + } cqicb->sbq_addr = cpu_to_le64(rx_ring->sbq.base_indirect_dma); cqicb->sbq_buf_size = cpu_to_le16(SMALL_BUFFER_SIZE);