From: Dan Carpenter Date: Tue, 20 Apr 2021 08:44:51 +0000 (+0300) Subject: mtd: rawnand: silence static checker warning in nand_setup_interface() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4d888eceb725216305eee595ff5d068112cf7c15;p=linux.git mtd: rawnand: silence static checker warning in nand_setup_interface() Smatch complains that the error code is not set on this error path: drivers/mtd/nand/raw/nand_base.c:842 nand_setup_interface() warn: missing error code 'ret' But actually returning success is intentional because the NAND chip will still work in mode 0. This patch adds a "ret = 0;" assignment to make the intent more clear and to silence the static checker warning. It doesn't affect the compiled code because GCC optimises the assignment away. Signed-off-by: Dan Carpenter Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/YH6Ugwz3gcga+q8X@mwanda --- diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index fb072c4444950..e29e5b3d31bf5 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -880,6 +880,7 @@ static int nand_setup_interface(struct nand_chip *chip, int chipnr) if (tmode_param[0] != chip->best_interface_config->timings.mode) { pr_warn("timing mode %d not acknowledged by the NAND chip\n", chip->best_interface_config->timings.mode); + ret = 0; goto err_reset_chip; }