From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 3 Sep 2019 19:12:09 +0000 (+0200)
Subject: fs-udf: Delete an unnecessary check before brelse()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4eb09e1112180672795f4238e9252531f607c7a7;p=linux.git

fs-udf: Delete an unnecessary check before brelse()

The brelse() function tests whether its argument is NULL
and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://lore.kernel.org/r/a254c1d1-0109-ab51-c67a-edc5c1c4b4cd@web.de
Signed-off-by: Jan Kara <jack@suse.cz>
---

diff --git a/fs/udf/super.c b/fs/udf/super.c
index 7ab29124961cb..8c28e93e9b730 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -269,8 +269,7 @@ static void udf_sb_free_bitmap(struct udf_bitmap *bitmap)
 	int nr_groups = bitmap->s_nr_groups;
 
 	for (i = 0; i < nr_groups; i++)
-		if (bitmap->s_block_bitmap[i])
-			brelse(bitmap->s_block_bitmap[i]);
+		brelse(bitmap->s_block_bitmap[i]);
 
 	kvfree(bitmap);
 }