From: Uwe Kleine-König Date: Wed, 22 Mar 2023 17:02:19 +0000 (+0100) Subject: drm/tegra: hdmi: Convert to platform remove callback returning void X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4ef19206b23b49041a3eeb4ea132a213e4f7b78c;p=linux.git drm/tegra: hdmi: Convert to platform remove callback returning void The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding --- diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c index 6798eea317df7..6eac54ae12053 100644 --- a/drivers/gpu/drm/tegra/hdmi.c +++ b/drivers/gpu/drm/tegra/hdmi.c @@ -1874,15 +1874,13 @@ static int tegra_hdmi_probe(struct platform_device *pdev) return 0; } -static int tegra_hdmi_remove(struct platform_device *pdev) +static void tegra_hdmi_remove(struct platform_device *pdev) { struct tegra_hdmi *hdmi = platform_get_drvdata(pdev); host1x_client_unregister(&hdmi->client); tegra_output_remove(&hdmi->output); - - return 0; } struct platform_driver tegra_hdmi_driver = { @@ -1891,5 +1889,5 @@ struct platform_driver tegra_hdmi_driver = { .of_match_table = tegra_hdmi_of_match, }, .probe = tegra_hdmi_probe, - .remove = tegra_hdmi_remove, + .remove_new = tegra_hdmi_remove, };